Tns Review

Three-lens agent review

Runs three read-only review agents in parallel, each with its own lens, then merges their findings. Invoking this skill is the explicit request to spawn subagents.

When this is worth it

Worth it: a feature branch before the PR, a change that touches equipment control, connection handling or a shared store, anything that has to work in both NINA and PINS mode.

Not worth it: a one-line fix, a locale-only change, generated files. Use the built-in /code-review for generic correctness passes — this skill exists for the project-specific rules a generic reviewer cannot know.

Step 1 — determine the scope

git diff --stat                        # working tree
git diff origin/develop...HEAD --stat  # branch, when the working tree is clean

Default: review the working-tree diff. If it is empty, review origin/develop...HEAD. If both are empty, stop and say so — do not invent a scope. An argument (/tns-review <ref|path>) overrides this.

Read the diff yourself before spawning. The agents need a concrete brief, not "review the branch": which files, which layers (component / store / service), which runtime modes are affected, and whether native (Capacitor) code is touched.

Step 2 — spawn all three agents in one message

Use subagent_type: "general-purpose", all three in a single message so they run in parallel. Give each the same scope block, then its own checklist.

Every agent prompt must carry these constraints verbatim:

Read-only review. Do not edit, write or create any file. Do not commit, and do not run builds, installs or anything that mutates the repository — git diff, git show, grep and reading files only. Report findings; do not fix them. Every finding needs a concrete failure scenario (input or state → wrong behavior). A finding you cannot back with one is not a finding — drop it. State for each finding whether you verified it in the code or are inferring it.

Agent 1 — Functionality

• Both runtime modes. Does this work in NINA and PINS mode? A field that only one stack reports must be feature-detected on the payload, not branched on store.isPINS — the pattern is src/store/cameraStore.js:109 (TempChangeRunning), which falls back to a heuristic when the field is absent.
• Polling contract. /v2/socket does not deliver every state change, so polling must not be replaced by WebSocket events. Every new or changed poller goes through createPoller (src/utils/poller.js:9) or useBackgroundAwarePolling (src/utils/appLifecycle.js:27) and pauses when the app is backgrounded.
• Equipment safety. Connection ordering (switch first with its 5 s wait, mount before guider), profile writes via apiService.profileChangeValue, device selection via setProfileDevice (src/utils/equipmentDevices.js) so it survives the next device-list refresh.
• Races. Stale responses overwriting newer state, missing fetch generations, re-entrancy guards, and operations that take seconds (mount reconnect, driver reload, PHD2) without a loading flag.
• Error paths. Backend restart, request timeout, a field missing from the payload, an empty device list — what does the user see?
• i18n keys referenced in the diff exist in src/locales/en.json.

Agent 2 — UI

• Mobile-first. Narrow viewports, safe areas, orientation changes. Primary controls keep a 48 px touch target (min-h-touch / min-w-touch, defined via --spacing-touch in src/assets/tailwind.css:36).
• Design system. Use the tns-* utilities (tns-card, tns-btn-primary, tns-btn-secondary, tns-btn-danger, tns-input, tns-select, tns-status-*), not the legacy raw gray/cyan palette still present in older screens.
• Low-light operation. Contrast and dark-mode readability must not regress; modals and dialogs stay operable.
• z-index staffing: Modal 40, LoadingOverlay 60, setup wizard 70, modals opened from the wizard 75, LocationSyncModal 76, PINS upgrade overlay and DialogModal 80. Anything teleported to body needs an explicit value.
• Drag & drop: every <draggable> needs :fallbackOnBody="true"; never forceFallback: true; watch for backdrop-filter on a parent, which creates a containing block for position: fixed and misplaces the ghost on Android Chrome.
• Text. No hardcoded user-facing strings. Layout survives longer translations — German runs roughly 30% longer than English.