Agent skill

TiDB Change Instruction Critic

by pingcap in pingcap/tidb

Checks a fix proposed by a user or reviewer for intent, correctness and compatibility before the agent implements it in the TiDB codebase.

Apache-2.0Auto-check passedDevelopment

Install TiDB Change Instruction Critic

skills CLI
$ npx skills add pingcap/tidb --skill tidb-change-instruction-critic -a claude-code

Project install by default; add -g for ~/.claude/skills/.

GitHub CLI
$ gh skill install pingcap/tidb tidb-change-instruction-critic --agent claude-code

Project scope by default; add --scope user for a personal install. Needs GitHub CLI 2.90.0 or later (public preview).

Manual copy
$ git clone --depth 1 https://github.com/pingcap/tidb.git skills-src && mkdir -p .claude/skills && cp -r skills-src/.agents/skills/tidb-change-instruction-critic .claude/skills/tidb-change-instruction-critic && rm -rf skills-src

Use ~/.claude/skills/ instead of .claude/skills for a personal install. The folder must contain SKILL.md.

Claude Code skills documentation · loads skills from .claude/skills/

Facts

Skill name
tidb-change-instruction-critic
GitHub stars
41k
Token cost
~523 tokens
SKILL.md length
267 words
Files
1
Skills in repo
9
Repo updated
First seen
Licence
Apache-2.0

At a glance

Checks a fix proposed by a user or reviewer for intent, correctness and compatibility before the agent implements it in the TiDB codebase.

  • Acting on review comments that prescribe a specific fix
  • SKILL.md covers Assess the proposed approach, Resolve uncertainty and Implement and validate
  • Instructions only: no scripts, shell commands, URLs or credentials in SKILL.md
  • Evaluating whether a proposed TiDB change keeps SQL behavior compatible

What it does

Before acting on a concrete approach from you or a code reviewer, such as review comments carrying fix instructions or solution options, the agent treats the proposal as a hypothesis to test against the intended outcome and existing contracts. Explicit requirements stay binding, and scope or SQL semantics are never changed silently to make the work easier. It checks the problem in code, tests and review context first, then weighs correctness, compatibility, performance, maintainability and available validation, comparing alternatives only when there is a real tradeoff.

Questions that code, tests or the conversation can answer are investigated instead of asked. The agent asks one concise question only when a requirement stays unresolved, a contract tradeoff needs your decision, or the work would leave the authorized scope, pausing only the dependent change. When the approach is sound and authorized, it proceeds without a separate checkpoint and explains any departure from the suggestion. The diff stays focused on the agreed intent, regression coverage follows `AGENTS.md`, and the final report states the behavior, evidence and residual risks.

When your agent uses it

  • Acting on review comments that prescribe a specific fix
  • Evaluating whether a proposed TiDB change keeps SQL behavior compatible
  • Deciding when to ask a question and when to proceed with a proposed approach

Example prompts

  • “The reviewer suggests caching the plan in the optimizer; assess that before you implement it.”
  • “Here are the fix instructions from the PR comments; check them for correctness and compatibility first.”
  • “Compare my proposed change with the alternative and implement whichever keeps SQL semantics intact.”

Requirements

  • A TiDB checkout with its AGENTS.md file

What it can do on your machine

Read from SKILL.md and the folder at commit 77bf7cb. It shows what the files ask for, not the result of running them.

  • Tool permissions

    Pre-approves nothing: there is no allowed-tools line, so your agent's usual permission prompts apply.

    From allowed-tools in the SKILL.md frontmatter.

  • Runs code

    No scripts in the folder and no shell commands in SKILL.md.

    From the folder's file list and the shell code blocks in SKILL.md.

  • Network

    No URLs in SKILL.md.

    From URLs in SKILL.md, links to its own repository left out.

  • Credentials

    Names no API keys, tokens, secrets or passwords.

    From names ending in _API_KEY, _TOKEN, _SECRET, _KEY or _PASSWORD in SKILL.md.

Context cost

TiDB Change Instruction Critic loads about 523 tokens when it runs. Until then it costs about 35 tokens; SKILL.md has 267 words of instructions outside code blocks.

Always · name and description, kept in context so the agent knows when to use it
~35
When it runs · the whole SKILL.md, loaded when a task matches
~523

Estimates: characters ÷ 4, the usual rule of thumb; real counts depend on the model's tokenizer. Scripts and assets cost tokens only if the agent reads them.

Safety

Auto-check passed

The automated check found no risky patterns in SKILL.md.

Automated static check — not a guarantee. Review scripts before installing. It scans the text of SKILL.md for risky patterns (piping downloads into a shell, reading credential files, hidden Unicode, destructive commands); files beside SKILL.md are not scanned.

SKILL.md

The full file from pingcap/tidb at commit 77bf7cb, republished under its Apache-2.0 licence (© pingcap). 267 words, ~523 tokens.

Download SKILL.mdSave it as .claude/skills/tidb-change-instruction-critic/SKILL.md (or your agent's skills folder).
name
tidb-change-instruction-critic
description
Assess user- or reviewer-proposed TiDB fixes before implementation for intent, correctness, and compatibility.

TiDB Change Instruction Critic

Use this skill before implementing a concrete approach proposed by the user or a reviewer, including review comments with fix instructions or solution options.

Assess the proposed approach

Treat the proposed method as a hypothesis to check against the intended outcome and existing contracts. Explicit user requirements remain constraints; do not silently change scope or SQL semantics to make an implementation easier.

  • Check the problem and relevant behavior in code, tests, and review context before editing.
  • Evaluate the requested approach for correctness, compatibility, performance, maintainability, and available validation. Compare alternatives when there is a material tradeoff; do not manufacture options for a straightforward change.
  • Prefer the approach that satisfies the intended contract. Use lower risk to choose among otherwise suitable approaches, rather than as a reason to leave the actual problem unresolved.

Resolve uncertainty

Investigate questions that code, tests, or the existing conversation can answer. Risk, a possible semantic impact, or an initially unclear validation plan does not by itself require another confirmation.

Ask a concise question only when investigation leaves an unresolved requirement, a contract tradeoff the user must decide, or work outside the authorized scope. Explain the concrete decision and its consequence. Pause the dependent change while continuing independent authorized work.

When the approach is sound and authorized, proceed without a separate alignment checkpoint. Explain material departures from a suggested method or remaining tradeoffs; a fixed options report before every edit is unnecessary.

Implement and validate

Keep the diff focused on the agreed intent. Follow AGENTS.md for regression coverage and validation, and report the resulting behavior, supporting evidence, and residual risks.

© pingcap, Apache-2.0. Rendered from Markdown: HTML in the file is shown as text, images as links, and headings moved down two levels. Raw file

Files

Just SKILL.md in .agents/skills/tidb-change-instruction-critic of pingcap/tidb.

Open the folder on GitHubat commit 77bf7cb

Compare with similar skills

TiDB Change Instruction Critic next to the 5 skills that share the most tags, products or categories with it. Stars are the repository's; “used in” counts other GitHub owners with a copy.

TiDB Change Instruction Critic compared with similar skills
SkillStarsUsed inTokensAuto-checkLicenceRepo updated
TiDB Change Instruction Critic this skillpingcap/tidb41k—~523Automated safety check: PassApache-2.0
SeekDB Code Reviewoceanbase/seekdb3.1k—~2.1kAutomated safety check: PassApache-2.0
Code ReviewClickHouse/clickhouse-java1.6k—~290Automated safety check: PassApache-2.0
PR Babysitteropeninterpreter/openinterpreter69k3 repos~4.2kAutomated safety check: PassApache-2.0
WooCommerce Code Reviewwoocommerce/woocommerce11k3 repos~1.1kAutomated safety check: PassCustom licence
Open Code Review CLIalibaba/open-code-review46k—~3.1kAutomated safety check: PassApache-2.0

Similar skills

  • SeekDB Code Review

    oceanbase/seekdb

    Reviews seekdb pull requests and diffs for real defects in correctness, resources, concurrency, security and tests, reporting only Blocker or Major findings.

    3.1k GitHub stars~2.1k tokensUpdated today
    DevelopmentAuto-check passed
  • Code Review

    ClickHouse/clickhouse-java

    Review changes in clickhouse-java for correctness, compatibility, API stability, and missing tests.

    1.6k GitHub stars~290 tokensUpdated yesterday
    DevelopmentAuto-check passed
  • PR Babysitter

    openinterpreter/openinterpreter

    Watches an open GitHub pull request until it merges, handling review comments, diagnosing CI failures and retrying flaky checks along the way.

    69k GitHub starsUsed in 3 repos~4.2k tokens
    DevelopmentAuto-check passed
  • WooCommerce Code Review

    woocommerce/woocommerce

    Reviews WooCommerce code changes against the project's standards, flagging backend PHP architecture, naming, documentation, data integrity and testing violations.

    11k GitHub starsUsed in 3 repos~1.1k tokens
    DevelopmentAuto-check passed
  • Open Code Review CLI

    alibaba/open-code-review

    Runs the ocr command-line tool to review Git changes, a commit or a branch comparison with an AI model, returning line-level comments and optionally applying fixes.

    46k GitHub stars~3.1k tokensUpdated yesterday
    DevelopmentAuto-check passed
  • Official

    Runs a loop on a GitHub pull request: fetch review state, triage comments into actions, implement them and resolve threads, repeating until nothing actionable is left.

    48k GitHub stars~2.2k tokensUpdated yesterday
    DevelopmentAuto-check passed

More from pingcap/tidb

All 9 skills in this repo
  • Decides from local git changes whether make bazel_prepare must run in TiDB before build or test commands, and reports the evidence for the decision.

    41k GitHub stars~408 tokensUpdated today
    Auto-check passed
  • Investigates TiDB plan or test-result diffs that the change does not explain, ruling out failpoint setup and merge effects before expected outputs are updated.

    41k GitHub stars~498 tokensUpdated today
    Auto-check passed
  • Use when running TiDB package tests and deciding whether failpoint enable/disable is required before and after the test command.

    41k GitHub stars~256 tokensUpdated today
    Auto-check passed
  • Use when recording TiDB integration tests under tests/integrationtest and verifying regenerated result files stay minimal and correct.

    41k GitHub stars~260 tokensUpdated today
    Auto-check passed
  • Use when running tests under tests/realtikvtest that require a local TiUP playground lifecycle with strict startup, readiness checks, and cleanup.

    41k GitHub stars~250 tokensUpdated today
    Auto-check passed
  • Keeps TiDB GitHub issues consistent by following the issue templates, writing reproducible reports, checking for duplicates and applying labels explicitly.

    41k GitHub stars~1k tokensUpdated today
    Auto-check passed

Works with

Questions about TiDB Change Instruction Critic

What does TiDB Change Instruction Critic do?

Checks a fix proposed by a user or reviewer for intent, correctness and compatibility before the agent implements it in the TiDB codebase. Before acting on a concrete approach from you or a code reviewer, such as review comments carrying fix instructions or solution options, the agent treats the proposal as a hypothesis to test against the intended outcome and existing contracts. Explicit requirements stay binding, and scope or SQL semantics are never changed silently to make the work easier.

When should I use TiDB Change Instruction Critic?

TiDB Change Instruction Critic fits situations like: acting on review comments that prescribe a specific fix; evaluating whether a proposed TiDB change keeps SQL behavior compatible; deciding when to ask a question and when to proceed with a proposed approach.

How do I install TiDB Change Instruction Critic in Claude Code?

Run `npx skills add pingcap/tidb --skill tidb-change-instruction-critic -a claude-code`. Or copy the skill folder (.agents/skills/tidb-change-instruction-critic in pingcap/tidb) into .claude/skills/tidb-change-instruction-critic in your project. Claude Code loads it when a task matches its description.

How do I install TiDB Change Instruction Critic in Codex?

Run `npx skills add pingcap/tidb --skill tidb-change-instruction-critic -a codex`. Or copy the skill folder (.agents/skills/tidb-change-instruction-critic in pingcap/tidb) into .agents/skills/tidb-change-instruction-critic in your project. Codex loads it when a task matches its description.

Can I use TiDB Change Instruction Critic in Cursor, Gemini CLI or GitHub Copilot?

Cursor, Gemini CLI, GitHub Copilot and OpenCode also load SKILL.md folders. With the skills CLI, run `npx skills add pingcap/tidb --skill tidb-change-instruction-critic -a cursor` (or -a gemini-cli, github-copilot or opencode for the others). To copy it by hand, put the folder in .cursor/skills/tidb-change-instruction-critic, .gemini/skills/tidb-change-instruction-critic, .github/skills/tidb-change-instruction-critic and .opencode/skills/tidb-change-instruction-critic in your project.

What does TiDB Change Instruction Critic need to run?

SKILL.md names no scripts, command-line tools or credentials: TiDB Change Instruction Critic is instructions for the agent only. Our summary lists: A TiDB checkout with its AGENTS.md file.

Does TiDB Change Instruction Critic access the network?

SKILL.md contains no URLs. Any network use would come from the scripts or tools the agent runs. This is read from the text; nothing was executed.

Is TiDB Change Instruction Critic safe to install?

Our automated static check of SKILL.md found no risky patterns, such as piping downloads into a shell, reading credential files or hidden Unicode. It is not a guarantee. Review the folder before installing.

What licence does TiDB Change Instruction Critic use?

TiDB Change Instruction Critic is published under the Apache-2.0 licence (the repository's licence). It allows redistribution, so the full SKILL.md is shown on this page.

How many tokens does TiDB Change Instruction Critic use?

About 523 tokens (SKILL.md is roughly 2.1k characters). Agents keep only the skill's name and description in context until a task matches; then they load SKILL.md in full.

What are the alternatives to TiDB Change Instruction Critic?

Skills that share tags, products or a category with TiDB Change Instruction Critic: SeekDB Code Review (oceanbase/seekdb, 3.1k stars), Code Review (ClickHouse/clickhouse-java, 1.6k stars), PR Babysitter (openinterpreter/openinterpreter, 69k stars) and WooCommerce Code Review (woocommerce/woocommerce, 11k stars). The comparison table on this page puts their stars, adoption, token cost, safety result and licence side by side.

Who maintains TiDB Change Instruction Critic?

pingcap (a GitHub organization) maintains it in pingcap/tidb, which has 40,630 GitHub stars. The repository holds 9 skills in this directory. The repository was last updated on October 10, 2026.

Source: pingcap/tidb on GitHub. Facts on this page come from the repository at the commit we read; the author's words are quoted as theirs.