PR Iterate

8. Address Review Feedback

After posting your review or after CI goes green, check for review comments from humans or other bots:

gh pr view <number> --repo <owner>/<repo> --comments
gh api repos/<owner>/<repo>/pulls/<number>/reviews
gh api repos/<owner>/<repo>/pulls/<number>/comments

For each unresolved review comment:

1. Understand the feedback — read the comment in context of the code it references
2. Fix the code if the feedback is actionable
3. ⚠️ Reply to EACH comment individually explaining what you did:

   # Get comment IDs
   gh api repos/<owner>/<repo>/pulls/<number>/comments --jq '.[].id'
   # Reply to each one
   gh api repos/<owner>/<repo>/pulls/<number>/comments/<comment-id>/replies \
     -f body="Fixed in <sha> — <what you changed and why>"

   This is mandatory. Every review comment must get its own reply describing the specific fix. Do not batch replies or skip this step.
4. Commit and push the fix (with Co-authored-by trailer)
5. File follow-up issues for valid feedback that is out of scope for this PR. Reply to the comment acknowledging the point and linking the new issue:

   gh issue create --repo <owner>/<repo> \
     --title "<concise title>" \
     --body "Follow-up from PR #<number> review. <description>"
   gh api repos/<owner>/<repo>/pulls/<number>/comments \
     -f body="🤖 Valid point — filed #<issue> as a follow-up." \
     -F in_reply_to=<comment-id>

If a review requests changes, address all comments before re-requesting review. After pushing fixes, go back to step 6 to monitor CI.

9. Iterate

Repeat steps 5-8 until CI is fully green, merge conflicts are resolved, and all review comments are addressed (either fixed or filed as follow-ups). Then verify:

gh pr checks <number> --repo <owner>/<repo>

Once all checks pass:

1. Re-request a review from @copilot so the Copilot code review bot validates the final state of the PR:

   gh pr edit <number> --repo <owner>/<repo> --add-reviewer "@copilot"

   Wait for the Copilot review to appear (poll with gh api repos/<owner>/<repo>/pulls/<number>/reviews). If Copilot leaves suggestions or requests changes, address them the same way as human review feedback (step 8) and re-request once fixed.

2. Capture a screenshot or GIF if the PR adds or modifies a sample. Build the solution first (dotnet build from the repo root), then use the screenshot or record script:

   # Screenshot (PNG)
   dotnet run scripts/screenshot-nes.cs -- samples/<name>/bin/Debug/net10.0/<name>.nes 4000 samples/<name>/<name>.png
   
   # Animated GIF (better for samples with movement)
   dotnet run scripts/record-nes.cs -- samples/<name>/bin/Debug/net10.0/<name>.nes --gif --output samples/<name>/<name>.gif

   Upload the image to the PR comment so reviewers can see the result without running it locally.

3. Post a final comment with the screenshot/GIF attached:

   # Upload the image and include it in the comment
   gh pr comment <number> --repo <owner>/<repo> --body "🤖 CI is green. Ready for human review.
   
   ![<name> sample](samples/<name>/<name>.png)"

   If the PR does NOT involve a sample (e.g., analyzer changes, build fixes), just post the text comment without a screenshot.

Important Rules

• Never commit or push directly to main — all changes go through PRs, no exceptions
• Never merge — the human reviews and merges
• Never force-push — always push incremental commits
• Always reply to each review comment individually — use the /replies API endpoint for each comment ID. Never skip this even if you addressed all feedback in a single commit.
• Always use dotnet test without --no-build — the test project requires fresh builds
• Use Start-Process with redirected output for dotnet test — it hangs in interactive PowerShell due to MSBuild terminal output
• Prefix all GitHub comments/reviews with 🤖
• Include the Co-authored-by trailer in all commits